Jump to content

Member Badge Revival (WIP)


VincentASM
 Share

Recommended Posts

You may have noticed the recent forum upgrade nuked member badges.

I think "nuked" is an understatement, because the custom member badge code I made was rendered completely unusable between the bizarre syntax changes, impossible-to-find keys/IDs and removal of X=Y for custom profile fields (seriously WTF).

So I ended up spending FAR too many hours trying to remake the code and, after much sweat, facepalming and liberal cursing at the screen, I now have something that vaguely resembles the original code.

Current Progress

Badges only appear in the Serenes Forest skin. They will be added to the other skins when I've fine-tuned the code.

All regular members should be able to select a Member Badge and Allegiance. Staff and Editors are currently stuck with a default badge for now, but this can be changed later. Maybe.

SFS Badges and Staff Badges don't work. Mainly because the code is sloppy and it's a pain in the butt to implement.

Allegiance-specific badges are currently missing. Bringing them back will require an overhaul of the badge code, otherwise it'll become super duper messy.

Known Bugs

If you don't have a Member Badge or Allegiance selected, your member badge/allegiance may not display properly. In fact, I have no idea how you can have them NOT selected--and equally no idea why the failsafes don't kick in.

Update: Not having a Member Badge of Allegiance selected is very screwy. I dunno how to fix this right now.

Other

Any issues, let me know. Eg. missing badges or major screw ups.

Feel free to post in this topic to test your badge.

Edited by VincentASM
Link to comment
Share on other sites

  • Replies 61
  • Created
  • Last Reply

Top Posters In This Topic

Damn but have the badges turn out to be a headache. 

18 minutes ago, VincentASM said:

Known Bugs

If you don't have a Member Badge or Allegiance selected, your member badge/allegiance may not display properly. In fact, I have no idea how you can have them NOT selected--and equally no idea why the failsafes don't kick in.

When I go to Allegiance selection there's two "Not selected" options for me. An " " and "-" and mine is in the first one. I have never selected an allegiance before so maybe that's a one way to have it not selected. Or then it's something completely different.

Link to comment
Share on other sites

Umm

It says that Pixel Marth and all others SFS badges has priority over the normal badges

Yet I still have the Owain badge.

Edit: I choose another normal badge and now I don't see an image at all, only ''Shepherd'' and the Brand of the exalt

 Nvm but still no Pixel Marth, strange

Edited by Nym
Link to comment
Share on other sites

5 minutes ago, Jeheza said:

Damn but have the badges turn out to be a headache. 

When I go to Allegiance selection there's two "Not selected" options for me. An " " and "-" and mine is in the first one. I have never selected an allegiance before so maybe that's a one way to have it not selected. Or then it's something completely different.

Whoops, I thought I deleted that. Maybe I didn't press "Save".

Nah, your setup is within the failsafes. That's why your badge has no problems.

Link to comment
Share on other sites

You should probably check the prority for the SFS 2015 badges, because I think it doesn't work properly or at all.

Link to comment
Share on other sites

16 minutes ago, Brand_Of_The_Exalt said:

Huh, I don't see his badge. The same picture that appears when you post an image that doesn't work is into the frame instead.

Huh, whose badge? What skin are you using? Can you post a screenshot?

10 minutes ago, Nym said:

You should probably check the prority for the SFS 2015 badges, because I think it doesn't work properly or at all.

See:

54 minutes ago, VincentASM said:

SFS Badges and Staff Badges don't work. Mainly because the code is sloppy and it's a pain in the butt to implement.

 

Edited by VincentASM
Link to comment
Share on other sites

1 hour ago, VincentASM said:

Whoops, I thought I deleted that. Maybe I didn't press "Save".

Nah, your setup is within the failsafes. That's why your badge has no problems.

Meanwhile I'm on the "-" option and am messed up. Heh.

Link to comment
Share on other sites

2 hours ago, VincentASM said:

Some members may have misaligned badges. I dunno why this happens. It took me long enough to align the badges for the majority of members.

If this helps, mine was misaligned at first and it went back to normal once I gave myself an allegiance, which centered it correctly
http://puu.sh/tx6pw.png
http://puu.sh/tx6q7.png

(and idk how much this matters or not but trying to set my allegiance to " " gave me an error code every time)

oh and if this is already what you meant by "may not display properly" right above the part I quoted then ignore me

Edited by Freohr Datia
Link to comment
Share on other sites

I've discovered a couple of sources of the issue with alignment of badges, like Sock's 

cb29db7574.png

a814eecfce.png

 

The first two options appear to be causing issues. The rest, I haven't tested thoroughly yet but appear to be fine.

Link to comment
Share on other sites

1 hour ago, Sock said:

Meanwhile I'm on the "-" option and am messed up. Heh.

Whoops, I was dumb. I meant to delete the "-" option. It should be gone now.

The proper Default option is the blank one.

Also some of the bugs are related to badges with name changes, eg. Fury -> Erinys and Raquesis -> Lachesis.

For example, despite being Erinys in the selector, the ID is Fury, which is absolutely infuriating, because you can't see the ID anywhere

Link to comment
Share on other sites

I believe the default of "None" is still causing issues. The "-" appears fixed, but users with no allegiance selected still seem rather borked, such as pianime94 in this post.

82e7ffb148.png

737b6218e6.png

No inner means no allegiance selected, from what I gather, meaning no default?

 

 

Link to comment
Share on other sites

It's even weirder than that.

I believe literally no value is passed, not even 0 or blank, which my code cannot account for.

Because you're supposed to get an image, even if it's a broken one. Not an entirely missing image...

	                {{if $value == '' OR $value == '-'}}
     <img class="inner" src='https://serenesforest.net/forums/uploads/badges/member/(default).gif' alt=''>
                {{else}}        
         <img class="inner" src='https://serenesforest.net/forums/uploads/badges/member/{$value}.gif' alt=''>
	{{endif}}
Edited by VincentASM
Link to comment
Share on other sites

Can you adjust the CSS globally to accomodate a default alignment, and/or assign a name to the null option (like, set it to Select, and just have Select give [nothing] as a result)?

Link to comment
Share on other sites

1 minute ago, Elieson said:

Can you adjust the CSS globally to accomodate a default alignment, and/or assign a name to the null option (like, set it to Select, and just have Select give [nothing] as a result)?

Perhaps, but it doesn't really solve the issue of the totally missing member overlay.

The latter is probably impossible because IPB is dumb.

Yeah, I just checked. In the case where no Allegiance is selected, it's neither A or B. WTF.

Hmm... I'm wracking my brains.

Link to comment
Share on other sites

Update the default value for current users with the 'blank' submittion to "Do Not Use", which i assume works properly at this point. It looks like this is a default setting for the combobox to have a blank option as the default null value, (since it's consistent with all three boxes). and I don't know if you can adjust the boxes themselves as well as the default values generated upon account creation, and/or update the data to change everyone's current default to DNU

Link to comment
Share on other sites

Just now, Elieson said:

Update the default value for current users with the 'blank' submittion to "Do Not Use", which i assume works properly at this point. It looks like this is a default setting for the combobox to have a blank option as the default null value, (since it's consistent with all three boxes). and I don't know if you can adjust the boxes themselves as well as the default values generated upon account creation, and/or update the data to change everyone's current default to DNU

That's what I'd like to do, but you can't change or do anything with the default option. IPB 4 is that dumb.

Seriously, half the problems are because of really weird/backwards design changes.

Just now, Brand_Of_The_Exalt said:

The is also out of badge too for me (or is it intended?):

a.jpg 

That was just me testing. Normally I use the test skin to muck around, but I was lazy : P

Anyway, I'll try and figure out the issues with the default selections later.

Link to comment
Share on other sites

Not sure if this is an issue for anyone else, but all the badges minus the staff badges appear to be misaligned.

Link to comment
Share on other sites

Guest
This topic is now closed to further replies.
 Share

  • Recently Browsing   0 members

    • No registered users viewing this page.
×
×
  • Create New...